Testing of books.name and books.filter.name book selection methods in /search API
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 41.05% 41.07% +0.02%
==========================================
Files 58 58
Lines 4190 4190
Branches 2304 2304
==========================================
+ Hits 1720 1721 +1
+ Misses 1003 1001 -2
- Partials 1467 1468 +1 ☔ View full report in Codecov by Sentry. |
This was mainly done to prevent further duplication of test data as more test points around the same query are added next but is also useful on its own.
mgautierfr
force-pushed
the
zim_name_vs_book_name
branch
from
a9a6ef5
to
e3fffd9
Compare
mgautierfr
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
kiwix-serve's/searchAPI there are two confusingly similar filtering parametersbooks.nameandbooks.filter.name. Their effect on book selection is very different from what one might expect from their names. This PR demonstrates the difference via unit tests.